Merged
Conversation
JackBoosY
added
the
category:port-update
JonLiu1993
reviewed
Apr 6, 2021
JonLiu1993
suggested changes
Apr 6, 2021
Contributor
JonLiu1993
left a comment
JonLiu1993
left a comment
There was a problem hiding this comment.
Please add the .PC file processing function vcpkg_fixup_pkgconfig() under vcpkg_install_make() in portifle.cmake
Contributor
|
@evpobr ,After you have modified everything, you should run the ./vcpkg x-add-version forge --overwrite-version command and then submit it again |
Contributor
Author
|
@JonLiu1993 , thanks, i know. I did everything I could without installing Vcpkg, which is impossible on this computer. I'll finish this pull request later tonight. |
JonLiu1993
approved these changes
Apr 7, 2021
JonLiu1993
added
info:needs-maintainer-attention
vicroms
requested changes
Apr 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add next version In continuation of the pull request #16910.